Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1846847 Add support for autocommit #555

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas commented Dec 5, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1846847
    Related issue: https://snowflake.discourse.group/t/sqlalchemy-how-to-remove-rollback-statements-for-simple-select-statements/13668

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

This PR doesn't fix unnecessary emitted rollbacks, instead it add support for setting autocommit isolation level when using engine.connect() funcition.

for example:


 with engine_testaccount.connect().execution_options(
            isolation_level="AUTOCOMMIT"
        );

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas requested a review from a team as a code owner December 5, 2024 13:46
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas changed the title Addd support for autocommit Add support for autocommit Dec 5, 2024
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas marked this pull request as draft December 5, 2024 13:46
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title Add support for autocommit SNOW-1846847 Add support for autocommit Dec 5, 2024
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas marked this pull request as ready for review December 9, 2024 13:52
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas enabled auto-merge (squash) December 16, 2024 21:03
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas merged commit d3e40d1 into main Dec 16, 2024
46 checks passed
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas deleted the add-support-autocommit branch December 16, 2024 21:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants