Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1655751: register overwritten functions under snowflake namespace #532

Merged
merged 3 commits into from
Oct 2, 2024
Merged

SNOW-1655751: register overwritten functions under snowflake namespace #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fea69c
SNOW-1655751: register overwritten functions under `snowflake` namespace
sfc-gh-mraba Sep 16, 2024
eceaf97
SNOW-1655751: update DESCRIPTION.m
sfc-gh-mraba Sep 16, 2024
2e9281a
SNOW-1655751: update DESCRIPTION.m
sfc-gh-mraba Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions DESCRIPTION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ Source code is also available at:

# Release Notes

- 1.6.2
- Fixed SAWarning when registering functions with existing name in default namespace

- v1.6.1(July 9, 2024)

- Update internal project workflow with pypi publishing
Expand All @@ -24,7 +27,7 @@ Source code is also available at:

- v1.5.3(April 16, 2024)

- Limit SQLAlchemy to < 2.0.0 before releasing version compatible with 2.0
- Limit SQLAlchemy to < 2.0.0 before releasing version compatible with 2.0

- v1.5.2(April 11, 2024)

Expand All @@ -33,7 +36,7 @@ Source code is also available at:

- v1.5.1(November 03, 2023)

- Fixed a compatibility issue with Snowflake Behavioral Change 1057 on outer lateral join, for more details check https://docs.snowflake.com/en/release-notes/bcr-bundles/2023_04/bcr-1057.
- Fixed a compatibility issue with Snowflake Behavioral Change 1057 on outer lateral join, for more details check <https://docs.snowflake.com/en/release-notes/bcr-bundles/2023_04/bcr-1057>.
- Fixed credentials with `externalbrowser` authentication not caching due to incorrect parsing of boolean query parameters.
- This fixes other boolean parameter passing to driver as well.

Expand Down
3 changes: 1 addition & 2 deletions src/snowflake/sqlalchemy/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ def _join_determine_implicit_left_side(self, raw_columns, left, right, onclause)
[element._from_objects for element in statement._where_criteria]
),
):

potential[from_clause] = ()

all_clauses = list(potential.keys())
Expand Down Expand Up @@ -1065,4 +1064,4 @@ def visit_GEOMETRY(self, type_, **kw):

construct_arguments = [(Table, {"clusterby": None})]

functions.register_function("flatten", flatten)
functions.register_function("flatten", flatten, "snowflake")
Loading