Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use the correct NullType. #524

Closed
wants to merge 1 commit into from

Conversation

DanCardin
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    It seemed silly to create an issue for something that's not typically a practical problem. But if this line is hit as is, you get

     >           type_instance = col_type(**col_type_kw)
     E           TypeError: 'NullType' object is not callable
    
  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    The originally referenced NULLTYPE is already an instance of NullType, so when the code goes to instantiate it, it fails. I imagine this code path is not currently tested then...

but it's not obvious to me how to go about adding any tests that depend on the connection like this function. Or at the very least, writing such a test without your test infrastructure would seem to be challenging.

@DanCardin DanCardin requested a review from a team as a code owner August 2, 2024 23:23
@sfc-gh-jvasquezrojas
Copy link
Collaborator

Hi @DanCardin,

Thank you for your contribution! The issue has been resolved in the following PR: here.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@DanCardin DanCardin deleted the dc/null_type branch November 25, 2024 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants