SNOW-685438: Sign artifacts before publish #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,8 @@ on: | |||
| types: [published] | |||
|
|
|||
| permissions: | |||
| contents: read | |||
| contents: write | |||
| id-token: write | |||
There was a problem hiding this comment.
can you please explain this change?
There was a problem hiding this comment.
id-token is required for signing the artifacts for cosign.
This github action will sign the artifacts using keyless process, verify signature using bundle file and certificate and sig files. Finally will copy the signing files to the release tag.
sfc-gh-pmikosz
approved these changes
Jul 23, 2024
sfc-gh-nsfard
approved these changes
Jul 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Signing artifacts with cosign before publishing them. The signing has the next steps: