Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow 1058245 sqlalchemy 20 support coverage test #471

Closed

Conversation

sfc-gh-astus
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

This config directives can be passed by hand if we want to remove setup.cfg.
For some reason defining in pyproject.toml [tool.sqla_testing] does not work.
…tatement

Version 2.0 wraps expression into parentheses:

1.4: str(users.c.name.like(users.c.name + "%s) -> 'users.name LIKE users.name || :name_1'
2.0: str(users.c.name.like(users.c.name + "%s) -> 'users.name LIKE (users.name || :name_1)'
Version 2.0 wraps expression into parentheses:

1.4: str(users.c.name.like(users.c.name + "%s) -> 'users.name LIKE users.name || :name_1'
2.0: str(users.c.name.like(users.c.name + "%s) -> 'users.name LIKE (users.name || :name_1)'
@sfc-gh-astus sfc-gh-astus deleted the SNOW-1058245-sqlalchemy-20-support-coverage-test branch March 5, 2024 09:35
@sfc-gh-astus sfc-gh-astus restored the SNOW-1058245-sqlalchemy-20-support-coverage-test branch March 5, 2024 09:35
@sfc-gh-astus sfc-gh-astus deleted the SNOW-1058245-sqlalchemy-20-support-coverage-test branch March 5, 2024 09:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants