Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow 1058245 SqlAlchemy 2.0 support #469

Merged
merged 17 commits into from
Jul 2, 2024
Merged

Snow 1058245 SqlAlchemy 2.0 support #469

merged 17 commits into from
Jul 2, 2024

Conversation

sfc-gh-mraba
Copy link
Collaborator

@sfc-gh-mraba sfc-gh-mraba commented Feb 16, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1058245

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
    • I am adding compatibility with SQLAlchemy 2.0

  3. Please describe how your code solves the related issue.

We adapted SnowflakeDialect compatibility with SQLAlchemy 2.0.
We added testing jobs with SQLAlchemy 2.0 installed.
We moved from tox to hatch.

@sfc-gh-mraba sfc-gh-mraba self-assigned this Feb 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-astus
Copy link
Collaborator

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-mraba sfc-gh-mraba changed the title Snow 1058245 sqlalchemy 20 support Snow 1058245 SqlAlchemy 2.0 support Mar 11, 2024
@sfc-gh-astus sfc-gh-astus force-pushed the SNOW-1058245-sqlalchemy-20-support branch from 4af8296 to f1823db Compare March 13, 2024 14:47
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch from 6f74862 to 5bfa71a Compare March 26, 2024 14:42
@sfc-gh-mraba sfc-gh-mraba marked this pull request as ready for review March 26, 2024 15:37
@sfc-gh-mraba sfc-gh-mraba requested a review from a team March 26, 2024 15:37
sfc-gh-astus
sfc-gh-astus reviewed Mar 28, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@antonrh
Copy link

antonrh commented Apr 12, 2024

🚀

@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch 2 times, most recently from ce3a4c3 to 2d1e343 Compare April 16, 2024 06:40
@nitin-kakkar
Copy link

nitin-kakkar commented Apr 18, 2024 •
edited
Loading

@sfc-gh-mraba - Thanks for adding 2.0 support. Do you have any timeline of when this version will be released? 🥺

@nitin-kakkar
Copy link

@sfc-gh-mraba - Thanks for adding 2.0 support. Do you have any timeline of when this version will be released? 🥺

Would really appreciate if you could provide some timeline. Thanks!!

@satniks
Copy link

satniks commented Apr 19, 2024

It looks like implementation is completed and pull request is also approved. Any timelines for merging it and releasing ne version of snowflake-sqlalchemy?

@sjhewitt
Copy link
Contributor

fwiw, I've been running this code in production for a few days and had no issues

@sfc-gh-dszmolka
Copy link
Contributor

hey folks thank you for the interest; please head to the pinned issue #380 for timeline and updates - i'll post there as soon as there's any news or more fresh ETA

@sjhewitt appreciate your comment very much, good to hear the changes are running without major issues !

@rafaelclp rafaelclp mentioned this pull request Apr 22, 2024
Closed
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch 4 times, most recently from cd98156 to 6a309e6 Compare April 25, 2024 07:46
@nitin-kakkar
Copy link

@sfc-gh-mraba - Is there any update on timelines for merging and releasing new version of snowflake-sqlalchemy?

@sfc-gh-dszmolka
Copy link
Contributor

@nitin-kakkar please head to the pinned issue #380 for timeline and updates - i'll post there as soon as there's any news or more fresh ETA

sfc-gh-mraba added 12 commits May 10, 2024 16:07
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: after rebase fixes
10a603f
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: fix dependency names in test work…
fd446d4 
…flow
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: use default names for combined co…
d44c177 
…verage report
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: code review fixes
5c67384
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: sqlalchemy max version set to <= …
8a70f68 
…2.1.0
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: add CI check for package installa…
f8d855b 
…tion
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: add requirements.txt file for sny…
f021cf9 
…k scanning
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: remove unused files
d06bfd7
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: restore SQLAlchemy 2.0.x as depen…
503e318 
…decy after rebase
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: downgrade macos from latest to 13…
527c84b 
… for python3.8
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: empty commit
20474fe
@sfc-gh-mraba
SNOW-1058245-sqlalchemy-20-support: v20 macos downgrade
67b7c79
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch from 6ad23d0 to 67b7c79 Compare May 10, 2024 14:08
@mleot
Copy link

mleot commented May 22, 2024

Is this PR going to be merged soon? I saw changes have been approved but not all the checks are complete.

@artem-sereda
Copy link

Is this PR going to be merged soon? I saw changes have been approved but not all the checks are complete.

+1

@mleot
Copy link

mleot commented Jun 14, 2024

It looks like two actions are stuck but are required before automatically merging. Maybe a maintainer would be able to manually start these two actions?

@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1058245-sqlalchemy-20-support branch from fdb1925 to 157bb78 Compare July 2, 2024 08:08
@sfc-gh-mraba sfc-gh-mraba merged commit d78f0c0 into main Jul 2, 2024
45 checks passed
@sfc-gh-mraba sfc-gh-mraba deleted the SNOW-1058245-sqlalchemy-20-support branch July 2, 2024 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pjob sfc-gh-pjob sfc-gh-pjob approved these changes

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees

@sfc-gh-mraba sfc-gh-mraba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sfc-gh-mraba @sfc-gh-astus @antonrh @nitin-kakkar @satniks @sjhewitt @sfc-gh-dszmolka @mleot @artem-sereda @sfc-gh-pjob