Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-876389: compatibility with bcr-1057 on outer lateral table join #444

Merged
merged 9 commits into from
Oct 10, 2023
Merged

SNOW-876389: compatibility with bcr-1057 on outer lateral table join #444

merged 9 commits into from
Oct 10, 2023

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Aug 30, 2023 •
edited by jira bot
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-876389, fix compatibility with BCR-1057

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aling sfc-gh-aling force-pushed the SNOW-876389-lateral-table-join branch from 78b4e83 to 6f0f15d Compare October 5, 2023 20:46
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review October 5, 2023 20:46
@sfc-gh-aling sfc-gh-aling changed the title Snow 876389: lateral table join bcr SNOW-876389: compatibility with bcr-1057 on outer lateral table join Oct 5, 2023
sfc-gh-mkeller
sfc-gh-mkeller approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

src/snowflake/sqlalchemy/base.py Show resolved Hide resolved
src/snowflake/sqlalchemy/base.py Show resolved Hide resolved
src/snowflake/sqlalchemy/base.py Show resolved Hide resolved
src/snowflake/sqlalchemy/base.py Outdated Show resolved Hide resolved
src/snowflake/sqlalchemy/base.py Show resolved Hide resolved
src/snowflake/sqlalchemy/base.py Show resolved Hide resolved
src/snowflake/sqlalchemy/base.py Show resolved Hide resolved
src/snowflake/sqlalchemy/base.py Show resolved Hide resolved
tests/test_orm.py Outdated Show resolved Hide resolved
tests/test_orm.py Outdated Show resolved Hide resolved
@sfc-gh-aling sfc-gh-aling merged commit 83f69b8 into main Oct 10, 2023
15 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-876389-lateral-table-join branch October 10, 2023 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-aling @sfc-gh-mkeller