Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INSERT support for OBJECT #320

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

luciengaitskell
Copy link

@luciengaitskell luciengaitskell commented Jul 20, 2022

Requires #319

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes (half of) Semistructured Data support for UPDATE and INSERT #107

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    When OBJECTs are inserted, the query is rewritten to use a SELECT to support the use of parse_json.

This suggestion originated from the SQLAlchemy maintainer:
sqlalchemy/sqlalchemy#7894 (reply in thread)

@luciengaitskell luciengaitskell marked this pull request as draft July 20, 2022 16:54
@luciengaitskell
Copy link
Author

Waiting for #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant