Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance the CreateFileFormat command #293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chaami
Copy link

@chaami chaami commented May 13, 2022

Adds support for if not exists options and for file format comment.

Fixes SNOW-589962

  • I am adding a new automated test(s) to verify correctness of my new code
  • I am adding new logging messages
  • I am adding new credentials
  • I am adding a new dependency

The change keeps the (relatively poor) CreateFileFormat constructor parameter naming for compatibility's sake and add additional ones to complete the feature.
Internal attributes are named closed to the Snowflake language names.

Adds support for if not exists options and for file format comment.

Fixes SNOW-589962
@chaami chaami requested a review from sfc-gh-mkeller as a code owner May 13, 2022 10:10
@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Amine Chadly seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@chaami
Copy link
Author

chaami commented Jun 1, 2022

I have read the CLA Document and I hereby sign the CLA

@chaami
Copy link
Author

chaami commented Jun 1, 2022

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant