Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1805174 Block iceberg mode with double buffer #999

Closed
wants to merge 1 commit into from
Closed

SNOW-1805174 Block iceberg mode with double buffer #999

wants to merge 1 commit into from
+37 −1

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Nov 14, 2024 •
edited
Loading

Overview

SNOW-1805174

Iceberg ingestion is failing for double buffer and it is not worth fixing it as single buffer will become a new default soon.

To make it user friendly I propose to make single buffer default for iceberg and return error when explicitly set to false.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner November 14, 2024 16:07
sfc-gh-mbobowski
sfc-gh-mbobowski commented Nov 14, 2024
View reviewed changes
src/main/java/com/snowflake/kafka/connector/SnowflakeSinkConnectorConfig.java
@@ -253,6 +254,18 @@ public static void setDefaultValues(Map<String, String> config) {
config, BUFFER_FLUSH_TIME_SEC, BUFFER_FLUSH_TIME_SEC_DEFAULT, "seconds");

if (isSnowpipeStreamingIngestion(config)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this code is executed before config validators are run.

@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-SNOW-1805174 branch November 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-mbobowski