Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
NO-SNOW
I need to have standard
com.fasterxml
to be compatible with IcebergUtils when parsing a KafkaRecord into Iceberg Type. Entire connector usesnet.snowflake.client.jdbc.internal.fasterxml
.It's because snowflake JDBC driver uses "shading" in its pom.xml. Even though the driver uses standard
com.fasterxml
after compiling it into a jar the package isnet.snowflake.client.jdbc.internal.fasterxml
.JDBC driver exposed telemetry method that requires
net.snowflake.client.jdbc.internal.fasterxml
as an argument -TelemetryUtil.buildJobData(ObjectNode obj)
. As a result the whole connector is bounded to the type inherited from the driver.There are to approaches two solve it:
com.fasterxml
->net.snowflake.client.jdbc.internal.fasterxml
inSnowflakeTelemetryService.send
method which I made in a first commit (see: link)net.snowflake.client.jdbc.internal.fasterxml
as it is only in telemetry related services (second commit)Or I can do hacks before parsing a json to Iceberg.
Pre-review checklist
snowflake.ingestion.method
.Yes
- Added end to end and Unit Tests.No
- Suggest why it is not param protected