-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1772187 nultiple columns evolution bug #980
Closed
sfc-gh-bzabek
wants to merge
1
commit into
master
from
bzabek-SNOW-1772187-multiple-fields-evolution-bug
+56
−2
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,6 @@ | |
import java.util.stream.Collectors; | ||
import java.util.stream.Stream; | ||
import org.apache.kafka.connect.sink.SinkRecord; | ||
import org.junit.jupiter.api.Disabled; | ||
import org.junit.jupiter.params.ParameterizedTest; | ||
import org.junit.jupiter.params.provider.Arguments; | ||
import org.junit.jupiter.params.provider.MethodSource; | ||
|
@@ -35,7 +34,7 @@ protected void createIcebergTable() { | |
|
||
@ParameterizedTest(name = "{0}") | ||
@MethodSource("prepareData") | ||
@Disabled | ||
// @Disabled | ||
void shouldEvolveSchemaAndInsertRecords( | ||
String description, String message, DescribeTableRow[] expectedSchema, boolean withSchema) | ||
throws Exception { | ||
|
@@ -81,6 +80,59 @@ void shouldEvolveSchemaAndInsertRecords( | |
assertRecordsInTable(); | ||
} | ||
|
||
@ParameterizedTest(name = "{0}") | ||
@MethodSource("prepareData") | ||
// @Disabled | ||
void shouldEvolveSchemaAndInsertRecords_withObjects( | ||
String description, String message, DescribeTableRow[] expectedSchema, boolean withSchema) | ||
throws Exception { | ||
// start off with just one column | ||
List<DescribeTableRow> rows = describeTable(tableName); | ||
assertThat(rows) | ||
.hasSize(1) | ||
.extracting(DescribeTableRow::getColumn) | ||
.contains(Utils.TABLE_COLUMN_METADATA); | ||
|
||
SinkRecord record = createKafkaRecord(message, 0, withSchema); | ||
service.insert(Collections.singletonList(record)); | ||
waitForOffset(-1); | ||
rows = describeTable(tableName); | ||
assertThat(rows.size()).isEqualTo(9); | ||
|
||
// don't check metadata column schema, we have different tests for that | ||
rows = | ||
rows.stream() | ||
.filter(r -> !r.getColumn().equals(Utils.TABLE_COLUMN_METADATA)) | ||
.collect(Collectors.toList()); | ||
|
||
assertThat(rows).containsExactlyInAnyOrder(expectedSchema); | ||
|
||
// resend and store same record without any issues now | ||
service.insert(Collections.singletonList(record)); | ||
waitForOffset(1); | ||
|
||
// and another record with same schema | ||
service.insert(Collections.singletonList(createKafkaRecord(message, 1, withSchema))); | ||
waitForOffset(2); | ||
|
||
String mapRecordJson = | ||
"{" | ||
+ " \"type\": \"map\", " | ||
+ " \"key-id\": 4, " | ||
+ " \"key\": \"string\", " | ||
+ " \"value-id\": 5, " | ||
+ " \"value-required\": false, " | ||
+ " \"value\": \"double\" " | ||
+ "}"; | ||
|
||
// reinsert record with extra field | ||
service.insert(Collections.singletonList(createKafkaRecord(mapRecordJson, 2, false))); | ||
rows = describeTable(tableName); | ||
assertThat(rows).hasSize(15); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Number of columns is correct. Schema evolution logic altered the table. |
||
service.insert(Collections.singletonList(createKafkaRecord(mapRecordJson, 2, false))); | ||
waitForOffset(3); // FAIL | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. However here it fails to ingest data. With error described in Jira |
||
} | ||
|
||
private void assertRecordsInTable() { | ||
List<RecordWithMetadata<PrimitiveJsonRecord>> recordsWithMetadata = | ||
selectAllSchematizedRecords(); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This insertion works fine. It adds 9 new columns.