Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1692749: Add assertions for records in table #964

Merged
merged 1 commit into from
Oct 21, 2024
Merged

SNOW-1692749: Add assertions for records in table #964

merged 1 commit into from
Oct 21, 2024

Conversation

sfc-gh-wtrefon
Copy link
Contributor

Overview

SNOW-1692749

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-wtrefon sfc-gh-wtrefon requested a review from a team as a code owner October 17, 2024 15:43
sfc-gh-mbobowski
sfc-gh-mbobowski reviewed Oct 21, 2024
View reviewed changes
src/test/java/com/snowflake/kafka/connector/streaming/iceberg/sql/PrimitiveJsonRecord.java
@JsonProperty("id_int8") Long idInt8,
@JsonProperty("id_int16") Long idInt16,
@JsonProperty("id_int32") Long idInt32,
// FIXME: there is currently some bug in Iceberg when storing int64 values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have some JIRA to remember about this problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://snowflakecomputing.atlassian.net/browse/SNOW-1754474

@sfc-gh-wtrefon sfc-gh-wtrefon merged commit cf5ff6a into master Oct 21, 2024
76 of 80 checks passed
@sfc-gh-wtrefon sfc-gh-wtrefon deleted the wtrefon/SNOW-1692749-extend-ITs branch October 21, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mbobowski sfc-gh-mbobowski sfc-gh-mbobowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-wtrefon @sfc-gh-mbobowski