Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1728000 Remove clean flag from tests #962

Merged
merged 1 commit into from
Oct 17, 2024
Merged

SNOW-1728000 Remove clean flag from tests #962

merged 1 commit into from
Oct 17, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Oct 16, 2024 •
edited
Loading

Overview

SNOW-1728000

The clean flag in e2e tests is always set to true so it can be deleted.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski marked this pull request as ready for review October 17, 2024 07:53
@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner October 17, 2024 07:53
sfc-gh-krosinski
sfc-gh-krosinski approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-krosinski sfc-gh-krosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-wtrefon
sfc-gh-wtrefon approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-wtrefon sfc-gh-wtrefon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xD

@sfc-gh-mbobowski sfc-gh-mbobowski merged commit f1f5900 into master Oct 17, 2024
78 of 80 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-SNOW-1728000-e2e-refactor branch October 17, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-krosinski sfc-gh-krosinski sfc-gh-krosinski approved these changes

@sfc-gh-wtrefon sfc-gh-wtrefon sfc-gh-wtrefon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-mbobowski @sfc-gh-wtrefon @sfc-gh-krosinski