Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-0000: extended telemetry with partitionId, fixed the event type sen… #958

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

sfc-gh-gjachimko
Copy link
Contributor

…t on cleaner progress, extended telemetry logging;

Overview

SNOW-0000:

Various telemetry improvements:

  • sending kafka_pipe_usage instead of kafka_pipe_start on progress report,
  • added partitionId to kafka_pipe_usage (important when troubleshooting issues for topics with many partitions)
  • added telemetry logging for failed stage access

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

…t on cleaner progress, extended telemetry logging;
@sfc-gh-gjachimko sfc-gh-gjachimko requested a review from a team as a code owner October 11, 2024 10:39
@sfc-gh-gjachimko sfc-gh-gjachimko merged commit eac2dcf into master Oct 14, 2024
80 checks passed
@sfc-gh-gjachimko sfc-gh-gjachimko deleted the gjachimko/NOSNOW_telemetry_improvements branch October 14, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants