Disable jmx by default #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-rcheng
requested review from
sfc-gh-japatel,
sfc-gh-tzhang,
sfc-gh-tjones and
a team
as code owners
| @@ -110,7 +110,7 @@ public class SnowflakeSinkConnectorConfig { | |||
|
|
|||
| // metrics | |||
| public static final String JMX_OPT = "jmx"; | |||
| public static final boolean JMX_OPT_DEFAULT = true; | |||
| public static final boolean JMX_OPT_DEFAULT = false; | |||
There was a problem hiding this comment.
Should we do it for snowpipe streaming only? otherwise we need to go through a BCR process
There was a problem hiding this comment.
sure, makes sense with streamings higher processing requirement. but why would snowpipe require BCR but not streaming?
sfc-gh-rcheng
force-pushed
the
rcheng-disablejmxdefault
branch
from
a9713a1 to
6edd211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JMX very slightly affects performance at high throughputs. This PR disables by default for both Snowpipe and Snowpipe Streaming, customers will have to enable it in the configuration.