-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-39429 Implement migrate sys func from new channel(Format V2) to old channel (V1) #750
PROD-39429 Implement migrate sys func from new channel(Format V2) to old channel (V1) #750
Conversation
c985826
to
45ee965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change should be merged into master first and then port to this branch?
Does the order matter? (I dont think so) Since you have commented on other one, lets get the discussion their and I will make sure its cp'ed in this branch too. |
45ee965
to
fe7e528
Compare
…ion system function
f186c2f
to
7b5e72d
Compare
@sfc-gh-tzhang @sfc-gh-rcheng I am going to push this to the release branch japatel-SNOW-971412-release-2-1-1-ready This branch will be used to release 2.1.1 (No need to update the release version) |
FYI, the tests were failing if I had schematization enabled and the first batch was missing on target table. Hence the new test I added had schematization off. I think this got fixed in later versions and is not a problem in main but we should be aware of this in this version. |
39bf407
into
japatel-SNOW-971412-release-2-1-1-ready
This is a long term implementation for potential data duplication introduced because of a new channel name format.
channelNameFormatV2
Added tests in
TopicPartitionChannel
andTopicPartitionChannel
Notes:
End to End tests:
Use 2.1.0
Use two connectors:
Uses channel Name v2
Stop
Replace jar (2.1.1) and restart.
Does the migration and you can only see old channel format
Stop again and restart in 2.1.1
Nothing happens and we do get a valid response saying newchannelFormatV2 doesnt exist