Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-532834 snowflake.role.name is optional for Snowpipe Streaming #749

Closed
wants to merge 3 commits into from
Closed

SNOW-532834 snowflake.role.name is optional for Snowpipe Streaming #749

wants to merge 3 commits into from

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Nov 16, 2023 •
edited
Loading

This PR makes 'snowflake.role.name' parameter in Snowpipe Streaming configuration optional.

Additionally it fixes a bug in unit tests so that they can actually fail when behaviour change.

sfc-gh-rcheng
sfc-gh-rcheng approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-rcheng sfc-gh-rcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix! lets wait for @sfc-gh-tzhang 's review as well since he has more context on the role removal

sfc-gh-japatel
sfc-gh-japatel approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks
As far as we are above v2.0.2 (ingest sdk) we should be able to use client without the role.

sfc-gh-tzhang
sfc-gh-tzhang approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Like I mentioned, there is a second change required for this JIRA, please make sure to handle that before closing

@sfc-gh-xhuang
Copy link
Collaborator

Please also test with schematization enabled. I believe Alec mentioned there were some complications with this change and schematization but I cannot find the exact notes

@sfc-gh-mbobowski
Copy link
Contributor Author

PR needs more work to handle schematization. Closing for now to prevent accidental merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-rcheng sfc-gh-rcheng sfc-gh-rcheng approved these changes

@sfc-gh-tzhang sfc-gh-tzhang sfc-gh-tzhang approved these changes

@sfc-gh-japatel sfc-gh-japatel sfc-gh-japatel approved these changes

@sfc-gh-tjones sfc-gh-tjones Awaiting requested review from sfc-gh-tjones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-mbobowski @sfc-gh-xhuang @sfc-gh-japatel @sfc-gh-tzhang @sfc-gh-rcheng