Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-913746 upgrade JDBC to 3.14.3 #740

Conversation

sfc-gh-japatel
Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel commented Nov 7, 2023

We need this for a customer who wants to use s3 + regional URL.

Here are supporting PRs which this change was originally dependent on:

  1. Server side: https://github.com/snowflakedb/snowflake/commit/208702b0a6bdc3639c46f0c4b8ef4375824456b6
  2. JDBC: snowflakedb/snowflake-jdbc@14c1318

Originally, it was released in 3.14.2 but 3.14.2 is backward incompatible change which impacts telemetry constructor from IngestSDK. Hence using 3.14.3

TLDR;

  • We use a response string from configure client API for snowpipe streaming.
  • We send this to get SnowflakeFileTransferMetadata Object.
  • JDBC needs to honor this variable and use the s3 regional URL.
  • This still needs the param set at an account level. (Please look at server side change for that)

We will push this to master as well as to a release branch for a requested customer.

@sfc-gh-japatel sfc-gh-japatel changed the title SNOW-913746 upgrade jdbc 3 14 2 SNOW-913746 upgrade JDBC to 3.14.2 Nov 7, 2023
@sfc-gh-japatel sfc-gh-japatel changed the base branch from master to sfkc-2.0.0-release-tag November 7, 2023 23:26
@sfc-gh-japatel sfc-gh-japatel changed the base branch from sfkc-2.0.0-release-tag to sfkc-2.0.1-release-tag November 7, 2023 23:39
@sfc-gh-japatel sfc-gh-japatel force-pushed the japatel-SNOW-913746-upgrade-jdbc-3-14-2 branch 2 times, most recently from 1599f1a to 96060e2 Compare November 7, 2023 23:52
@sfc-gh-japatel sfc-gh-japatel force-pushed the japatel-SNOW-913746-upgrade-jdbc-3-14-2 branch from 96060e2 to c152ac2 Compare November 8, 2023 00:17
@sfc-gh-japatel sfc-gh-japatel changed the title SNOW-913746 upgrade JDBC to 3.14.2 SNOW-913746 upgrade JDBC to 3.14.3 Nov 8, 2023
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to make sure this is on top of 2.0.0? And where is the change to upgrade the KC version?

@sfc-gh-japatel
Copy link
Collaborator Author

Want to make sure this is on top of 2.0.0? And where is the change to upgrade the KC version?

This is not on top of 2.0.0 because there was a bug fix in 2.0.1

I want to also push this to master! Upgrade will come later!

@sfc-gh-japatel sfc-gh-japatel reopened this Nov 8, 2023
@sfc-gh-japatel sfc-gh-japatel force-pushed the japatel-SNOW-913746-upgrade-jdbc-3-14-2 branch 2 times, most recently from da1636a to ee34788 Compare November 10, 2023 17:57
@sfc-gh-japatel sfc-gh-japatel force-pushed the japatel-SNOW-913746-upgrade-jdbc-3-14-2 branch from ee34788 to 5265fcd Compare November 10, 2023 19:05
@sfc-gh-japatel
Copy link
Collaborator Author

FYI, all apache tests are failing since our regex
snowflake-kafka-connector-[0-9].[0-9].[0-9]*.jar$

doesnt match with snowflake-kafka-connector-2.0.2-rc
It passes confluent because we copy entire zip file and dont do regex match. https://github.com/snowflakedb/snowflake-kafka-connector/blob/master/test/build_runtime_jar.sh#L109

I will ignore those errors for now since only bump up version commits are failing.

@sfc-gh-japatel
Copy link
Collaborator Author

Closing this PR, merged this change to master and also release 2.0.2-rc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants