SNOW-1731255: Put null or empty json nodes to DLQ for schema evolution #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-wtrefon
commented
Dec 5, 2024
| private void assertRecordsInTable() { | ||
| @Test | ||
| @Disabled | ||
| void shouldSendValueWithWrongTypeToDLQ() throws Exception { |
There was a problem hiding this comment.
additional test for unhappy path
| @ParameterizedTest(name = "{0}") | ||
| @MethodSource("wrongTypeValueMessages_dataSource") | ||
| @Disabled | ||
| void shouldSendValueWithWrongTypeToDLQ( |
There was a problem hiding this comment.
additional test for unhappy path
| List<InMemoryKafkaRecordErrorReporter.ReportedRecord> reportedRecords = | ||
| kafkaRecordErrorReporter.getReportedRecords(); | ||
| assertThat(reportedRecords).hasSize(2); | ||
| assertThat(reportedRecords.stream().map(it -> it.getRecord()).collect(Collectors.toList())) |
There was a problem hiding this comment.
If only it would be Kotlin...
There was a problem hiding this comment.
i try to forget... but still I sometimes remember the old good times
src/main/java/com/snowflake/kafka/connector/internal/SnowflakeErrors.java
Show resolved
Hide resolved
| } | ||
|
|
||
| private void assertRecordsInTable() { | ||
| @Test | ||
| @Disabled |
There was a problem hiding this comment.
sdk 3.0.1 has just been merged to master. You can rebase and enable all tests.
sfc-gh-bzabek
approved these changes
Dec 5, 2024
…ts-dlq # Conflicts: # src/test/java/com/snowflake/kafka/connector/streaming/iceberg/IcebergIngestionNoSchemaEvolutionIT.java
sfc-gh-mbobowski
approved these changes
Dec 5, 2024
sfc-gh-wtrefon
deleted the
wtrefon/SNOW-1731255-handle-null-empty-lists-dlq
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1731255
Pre-review checklist
snowflake.ingestion.method.Yes- Added end to end and Unit Tests.No- Suggest why it is not param protected