Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW Fix missing ubuntu packages error in CI #1011

Merged
merged 3 commits into from
Nov 29, 2024
Merged

NO-SNOW Fix missing ubuntu packages error in CI #1011

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1aa642
NO-SNOW Resolve problems with ubuntu packages that blocks CI
sfc-gh-mbobowski Nov 29, 2024
70c6fd8
NO-SNOW ubuntu-24.04
sfc-gh-mbobowski Nov 29, 2024
287bd28
NO-SNOW ubuntu-22.04 for e2es
sfc-gh-mbobowski Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/End2EndTestApache.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
build_and_test:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is super risky... I don't think we should do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the current latest instead of the latest tag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, I think I tried to bump it some time ago, and there were issues with some of the packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's try with 24.04 then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.04 works for non-Python workflows. For e2e tests there is some package version collision in 24.04, but not in 22.04.

If CI passes I will go on with combination of 22 and 24 to unblock development.

strategy:
fail-fast: false # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
matrix:
Expand Down Expand Up @@ -48,13 +48,13 @@ jobs:
pip3 install --upgrade protobuf==3.20.3
pip3 install --upgrade snowflake-connector-python==2.7.4
curl https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
sudo apt-get update
sudo apt-get -y install jq vim
sudo apt-get -y install protobuf-compiler

- name: Install Squid as Proxy Server and Apache Utils for Password Authentication
run: |
sudo apt-get update
sudo apt-get -y install squid3
sudo apt-get -y install squid
sudo apt-get install apache2-utils

- name: Change squid config and run Proxy Server
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/End2EndTestConfluent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
build_and_test:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
fail-fast: false # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
matrix:
Expand Down Expand Up @@ -48,13 +48,13 @@ jobs:
pip3 install --upgrade protobuf==3.20.3
pip3 install --upgrade snowflake-connector-python==2.7.4
curl https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
sudo apt-get update
sudo apt-get -y install jq vim
sudo apt-get -y install protobuf-compiler

- name: Install Squid as Proxy Server and Apache Utils for Password Authentication
run: |
sudo apt-get update
sudo apt-get -y install squid3
sudo apt-get -y install squid
sudo apt-get install apache2-utils

- name: Change squid config and run Proxy Server
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/IntegrationTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
build_and_test:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
fail-fast: false # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
matrix:
Expand Down Expand Up @@ -44,13 +44,13 @@ jobs:
pip3 install protobuf
pip3 install --upgrade snowflake-connector-python==2.7.4
curl https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
sudo apt update
sudo apt-get -y install jq vim
sudo apt-get -y install protobuf-compiler

- name: Install Squid as Proxy Server and Apache Utils for Password Authentication
run: |
sudo apt-get update
sudo apt-get -y install squid3
sudo apt-get -y install squid
sudo apt-get install apache2-utils

- name: Change squid config and run Proxy Server
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/StressTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ jobs:
pip3 install --upgrade protobuf==3.20.3
pip3 install --upgrade snowflake-connector-python==2.7.4
curl https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
sudo apt-get update
sudo apt-get -y install jq
sudo apt-get -y install protobuf-compiler

- name: Install Squid as Proxy Server and Apache Utils for Password Authentication
run: |
sudo apt-get update
sudo apt-get -y install squid3
sudo apt-get -y install squid
sudo apt-get install apache2-utils

- name: Change squid config and run Proxy Server
Expand Down
Loading