Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ConnectorConfigDefinition.java #1009

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update ConnectorConfigDefinition.java #1009

merged 1 commit into from
Nov 26, 2024

Conversation

sfc-gh-achyzy
Copy link
Contributor

Overview

NO-SNOW Update ConnectorConfigDefinition.java

This PR is a copy of #1008 to make merge gates pass.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-achyzy sfc-gh-achyzy requested a review from a team as a code owner November 25, 2024 08:06
@sfc-gh-mbobowski sfc-gh-mbobowski merged commit 0235f9f into master Nov 26, 2024
55 of 105 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the sudeshwasnik-connector-config-definition branch November 26, 2024 09:00
@sfc-gh-mbobowski sfc-gh-mbobowski mentioned this pull request Nov 26, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-gjachimko sfc-gh-gjachimko sfc-gh-gjachimko approved these changes

@sfc-gh-mbobowski sfc-gh-mbobowski sfc-gh-mbobowski approved these changes

@sudeshwasnik sudeshwasnik sudeshwasnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-achyzy @sudeshwasnik @sfc-gh-mbobowski @sfc-gh-gjachimko