Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1805174 Enable single buffer by default #1005

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

Overview

SNOW-1805174

This PR contains:

  • enabling single buffer by default + fixes for some tests
  • validation that blocks running iceberg ingestion with double buffer

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

Copy link

gitguardian bot commented Nov 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@@ -62,7 +62,7 @@ def send(self):
self.driver.sendBytesData(topic, value, key)

# Sleep for some time and then verify the rows are ingested
sleep(120)
sleep(100)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigated this test a little bit as it was the only one e2e that started to fail after my changes.

The test lasts for a significant amount of time not only because of ingest sdk lag, but also because of retry lags in KC framework itself (tried to tune it with "errors.retry.delay.max.ms" but didn't see any improvement). I also validated that the columns appear in the table with sleep(240) and default lag settings - anyway I decided to make it faster with lower lag.

@sfc-gh-mbobowski sfc-gh-mbobowski marked this pull request as ready for review November 20, 2024 16:27
@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner November 20, 2024 16:27
@sfc-gh-rsawicki sfc-gh-rsawicki merged commit e6f5154 into master Nov 22, 2024
48 of 54 checks passed
@sfc-gh-rsawicki sfc-gh-rsawicki deleted the mbobowski-SNOW-1805174 branch November 22, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants