-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1805174 Enable single buffer by default #1005
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
@@ -62,7 +62,7 @@ def send(self): | |||
self.driver.sendBytesData(topic, value, key) | |||
|
|||
# Sleep for some time and then verify the rows are ingested | |||
sleep(120) | |||
sleep(100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigated this test a little bit as it was the only one e2e that started to fail after my changes.
The test lasts for a significant amount of time not only because of ingest sdk lag, but also because of retry lags in KC framework itself (tried to tune it with "errors.retry.delay.max.ms" but didn't see any improvement). I also validated that the columns appear in the table with sleep(240)
and default lag settings - anyway I decided to make it faster with lower lag.
7ca6cfc
to
4cc734f
Compare
f8d5273
to
77ef150
Compare
Overview
SNOW-1805174
This PR contains:
Pre-review checklist
snowflake.ingestion.method
.Yes
- Added end to end and Unit Tests.No
- Suggest why it is not param protected