Skip to content

Commit

Permalink
SNOW-1686497 Remove single buffer warning for "buffer.size.bytes"
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-mbobowski committed Oct 7, 2024
1 parent 3bf31ff commit a9d8580
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,7 @@ private static class SingleBufferConfigValidator {

private void logDoubleBufferingParametersWarning(Map<String, String> config) {
if (InternalBufferParameters.isSingleBufferEnabled(config)) {
List<String> ignoredParameters =
Arrays.asList(BUFFER_FLUSH_TIME_SEC, BUFFER_SIZE_BYTES, BUFFER_COUNT_RECORDS);
List<String> ignoredParameters = Arrays.asList(BUFFER_FLUSH_TIME_SEC, BUFFER_COUNT_RECORDS);
ignoredParameters.stream()
.filter(config::containsKey)
.forEach(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void testRSAPasswordOutput() throws IOException, OperatorCreationExceptio
}

@ParameterizedTest
@ValueSource(strings = {BUFFER_FLUSH_TIME_SEC, BUFFER_SIZE_BYTES, BUFFER_COUNT_RECORDS})
@ValueSource(strings = {BUFFER_FLUSH_TIME_SEC, BUFFER_COUNT_RECORDS})
public void shouldLogWarningIfBufferingPropertiesDefinedForSingleBuffer(String parameter)
throws IOException {
// given
Expand Down

0 comments on commit a9d8580

Please sign in to comment.