Skip to content

Commit

Permalink
format and improve comment
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-bzabek committed Nov 12, 2024
1 parent 2a7dd77 commit 27e973f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ public SnowflakeStreamingIngestClient createClient(
SnowflakeStreamingIngestClientFactory.builder(
streamingClientProperties.clientName + "_" + createdClientId.getAndIncrement())
.setProperties(streamingClientProperties.clientProperties)
.setParameterOverrides(streamingClientProperties.parameterOverrides)
;
.setParameterOverrides(streamingClientProperties.parameterOverrides);

SnowflakeStreamingIngestClient createdClient = builder.build();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ public StreamingClientProperties(Map<String, String> connectorConfig) {
// Override only if the streaming client properties are explicitly set in config
this.parameterOverrides = new HashMap<>();
if (isIcebergEnabled) {
// todo extract to field
// TODO should be replaced by SnowflakeStreamingIngestClientFactory.builder.setIceberg(true)
// call in SNOW-1728002
this.parameterOverrides.put("enable_iceberg_streaming", "true");
}
Optional<String> snowpipeStreamingMaxClientLag =
Expand Down

0 comments on commit 27e973f

Please sign in to comment.