Add todos

snowflakedb · Oct 15, 2024 · 205f928 · 205f928
1 parent 9c1fb0a
commit 205f928
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/...n/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java b/...n/java/com/snowflake/kafka/connector/internal/streaming/DirectStreamingClientHandler.java
@@ -67,6 +67,7 @@ public SnowflakeStreamingIngestClient createClient(
 
   private static void enableIceberg(SnowflakeStreamingIngestClientFactory.Builder builder) {
     try {
+      // TODO reflection should be replaced by proper builder.setIceberg(true) call in SNOW-1728002
       FieldUtils.writeField(builder, "isIceberg", true, true);
     } catch (IllegalAccessException e) {
       throw new IllegalStateException(

diff --git a/src/main/java/com/snowflake/kafka/connector/records/RecordService.java b/src/main/java/com/snowflake/kafka/connector/records/RecordService.java
@@ -277,6 +277,7 @@ private Map<String, Object> processSnowflakeRecord(SnowflakeTableRow row)
 
   private Map<String, Object> processIcebergRecord(SnowflakeTableRow row)
       throws JsonProcessingException {
+    // TODO this not cover all cases, full implementation will be done in SNOW-1737840
     final Map<String, Object> streamingIngestRow = new HashMap<>();
     for (JsonNode node : row.content.getData()) {
       if (enableSchematization) {