-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1511108 SQLAlchemy heartbeat frequency parsed as string #1993
SNOW-1511108 SQLAlchemy heartbeat frequency parsed as string #1993
Conversation
Add the fix summary to DESCRIPTION.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please modify an already existing test case to check this?
🚢 🚢
* changed DESCRIPTION.md to have assumed next version
thank you again for the review @sfc-gh-mkeller ! could you please advise if skipping the 'Old Driver' test here would be okay? does it even have the change which we want to test here? (marked it as skipped it because it was the only one failed with the change, using PythonConnector 1.9.1 and all other tests/build passed) if you approve with this approach, i'll merge. Thank you in advance ! |
Please answer these questions before submitting your pull requests. Thanks!
When coming from (snowflake-)sqlalchemy's Engine, the
client_session_keep_alive_heartbeat_frequency
option seems to come as string, which then will crash the connector withWe already seem to have a protection mechanism against such occasions by converting the input to
int
, however when we do that, it's already too late because we already tried to comparestr
toint
and failed withTypeError
.Functionality isn't changed, just moved the conversion to happen before the comparison to
int
happens.