Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with list of accounts in release channels and directives #1998

Closed
wants to merge 1 commit into from
Closed

Fix issue with list of accounts in release channels and directives #1998

wants to merge 1 commit into from
+32 −17

Conversation

sfc-gh-melnacouzi
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Fixes:

  • target-accounts was not properly parsed as a list by typer. Changed approach.
  • catch one extra error code
  • tweak one error message
  • fix a bug with snow app run causing issue if release channel was Null

@sfc-gh-melnacouzi sfc-gh-melnacouzi requested a review from a team as a code owner January 16, 2025 23:06
@sfc-gh-melnacouzi sfc-gh-melnacouzi deleted the melnacouzi-fix-accounts-bug-cherry-pick branch January 17, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-melnacouzi