Add release channels list support #1953
Merged
+627
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,6 +136,99 @@ def ensure_app_roles_is_a_set( | |||
| return application_roles | |||
|
|
|||
|
|
|||
| class ReleaseChannel(dict[str, Any]): | |||
There was a problem hiding this comment.
Maybe specify the exact dict structure we're expecting with a TypedDict?
It's the same type that show_release_channels() returns, right? We can reuse it there too.
That way we would also be able to remove the type: ignore comments below.
src/snowflake/cli/_plugins/nativeapp/entities/application_package.py
Outdated
Show resolved
Hide resolved
| ) | ||
|
|
||
| formatted_created_on = ( | ||
| self.created_on.astimezone().strftime("%Y-%m-%d %H:%M:%S.%f %Z") |
There was a problem hiding this comment.
nit:
Why this specific format? Do we already print some datetimes elsewhere?
There was a problem hiding this comment.
From the design doc, Bruno wanted something more human readable for console output - in this case, we are outputting the current timezone.
Also, this is not set in stone, as it's only a console output. --format=json part is printed using the default.
sfc-gh-gbloom
approved these changes
Dec 16, 2024
sfc-gh-melnacouzi
deleted the
melnacouzi-add-release-channel-list-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Add support for
snow app release-channel list [CHANNEL]command.Integ tests will be added once UIParam is in production