Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable schema existence check for object create #1949

Merged
merged 2 commits into from
Dec 12, 2024
+4 −2
Merged

Temporarily disable schema existence check for object create #1949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
583b4fe
Temporarily disable schema existance check for object create
sfc-gh-pczajka Dec 12, 2024
3a283d1
skip test
sfc-gh-pczajka Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/snowflake/cli/api/rest_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,9 @@ def determine_url_for_create_query(
raise SchemaNotDefinedException(
"Schema not defined in connection. Please try again with `--schema` flag."
)
if not self._schema_exists(db_name=db, schema_name=schema):
raise SchemaNotExistsException(f"Schema '{schema}' does not exist.")
# temporarily disable this check due to an issue on server side: SNOW-1747450
# if not self._schema_exists(db_name=db, schema_name=schema):
# raise SchemaNotExistsException(f"Schema '{schema}' does not exist.")
if self.get_endpoint_exists(
url := f"{SF_REST_API_URL_PREFIX}/databases/{self.conn.database}/schemas/{self.conn.schema}/{plural_object_type}/"
):
Expand Down
1 change: 1 addition & 0 deletions tests_integration/test_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ def test_create_error_database_not_exist(runner):


@pytest.mark.integration
@pytest.mark.skip(reason="Server-side issue: SNOW-1855040")
def test_create_error_schema_not_exist(runner, test_database):
# schema does not exist
result = runner.invoke_with_connection(
Expand Down
Loading