Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not able to add patch to quoted versions #1943

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix not able to add patch to quoted versions #1943

merged 1 commit into from
Dec 11, 2024

Conversation

sfc-gh-melnacouzi
Copy link
Contributor

@sfc-gh-melnacouzi sfc-gh-melnacouzi commented Dec 10, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Adding patches to versions with non-SQL safe characters (like v1.0) was failing:
snow app version create v1.0 succeeds (creates a version)
snow app version create v1.0 fails - doesn't recognize that version was already created and attempts recreation
snow app version create v1.0 --patch 3 fails - doesn't recognize the version, so can't add patch.

@sfc-gh-melnacouzi sfc-gh-melnacouzi requested review from a team as code owners December 10, 2024 15:49
@sfc-gh-melnacouzi sfc-gh-melnacouzi enabled auto-merge (squash) December 10, 2024 15:57
@sfc-gh-melnacouzi sfc-gh-melnacouzi changed the title Fix not able to add patch to quoted versions SNOW-1852338 - Fix not able to add patch to quoted versions Dec 10, 2024
@sfc-gh-melnacouzi sfc-gh-melnacouzi enabled auto-merge (squash) December 10, 2024 15:59
@sfc-gh-melnacouzi sfc-gh-melnacouzi enabled auto-merge (squash) December 10, 2024 16:00
@sfc-gh-melnacouzi sfc-gh-melnacouzi changed the title SNOW-1852338 - Fix not able to add patch to quoted versions Fix not able to add patch to quoted versions Dec 10, 2024
@sfc-gh-melnacouzi sfc-gh-melnacouzi merged commit ce90044 into main Dec 11, 2024
20 checks passed
@sfc-gh-melnacouzi sfc-gh-melnacouzi deleted the melnacouzi-fix-version-patch-create-quoted branch December 11, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-gbloom sfc-gh-gbloom sfc-gh-gbloom approved these changes

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-melnacouzi @sfc-gh-astus @sfc-gh-gbloom