Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rebase issues in feature/unification-artifacts #1932

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix rebase issues in feature/unification-artifacts #1932

merged 1 commit into from
Dec 9, 2024

Conversation

sfc-gh-bdufour
Copy link
Contributor

@sfc-gh-bdufour sfc-gh-bdufour commented Dec 6, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

The feature branch is currently broken. This PR fixes the merge gates so that work can continue on the branch.

This is mostly work from @sfc-gh-astus, I just ensured that the quality gates pass (and removed the tweaks to pre-commit as they're not necessary and shouldn't be merged to main)

@sfc-gh-bdufour sfc-gh-bdufour force-pushed the features/unification-artifacts branch from d181eb7 to fe16b12 Compare December 6, 2024 17:53
@sfc-gh-bdufour sfc-gh-bdufour force-pushed the bdufour-fix-feature-branch branch from 094aa3c to de2df55 Compare December 6, 2024 17:54
@sfc-gh-bdufour sfc-gh-bdufour marked this pull request as ready for review December 6, 2024 18:13
@sfc-gh-bdufour sfc-gh-bdufour requested review from a team as code owners December 6, 2024 18:13
@sfc-gh-bdufour sfc-gh-bdufour removed the request for review from a team December 6, 2024 18:15
@sfc-gh-astus sfc-gh-astus merged commit 85d1c72 into features/unification-artifacts Dec 9, 2024
18 checks passed
@sfc-gh-astus sfc-gh-astus deleted the bdufour-fix-feature-branch branch December 9, 2024 09:05
sfc-gh-bdufour added a commit that referenced this pull request Dec 9, 2024
@sfc-gh-bdufour
Fix rebase issues in feature/unification-artifacts (#1932)
6281e35 
Fix feature branch gates
sfc-gh-astus pushed a commit that referenced this pull request Dec 12, 2024
@sfc-gh-bdufour @sfc-gh-astus
Fix rebase issues in feature/unification-artifacts (#1932)
660c412 
Fix feature branch gates
sfc-gh-astus pushed a commit that referenced this pull request Dec 13, 2024
@sfc-gh-bdufour @sfc-gh-astus
Fix rebase issues in feature/unification-artifacts (#1932)
1fe4e7c 
Fix feature branch gates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-bdufour @sfc-gh-astus