Downgrade snowpark lib until a fix is identified #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bdufour
commented
Dec 6, 2024
| @@ -35,7 +35,7 @@ dependencies = [ | |||
| "setuptools==75.6.0", | |||
| 'snowflake.core==1.0.2; python_version < "3.12"', | |||
| "snowflake-connector-python[secure-local-storage]==3.12.3", | |||
| 'snowflake-snowpark-python>=1.15.0;python_version < "3.12"', | |||
| 'snowflake-snowpark-python>=1.15.0,<1.26.0;python_version < "3.12"', | |||
There was a problem hiding this comment.
not entirely sure why the context.py alone wasn't sufficient, but I had to do this too for E2E to pass.
sfc-gh-astus
approved these changes
Dec 6, 2024
sfc-gh-melnacouzi
approved these changes
Dec 6, 2024
sfc-gh-pczajka
pushed a commit
that referenced
this pull request
Dec 12, 2024
sfc-gh-pczajka
added a commit
that referenced
this pull request
Dec 12, 2024
* Bump version * Downgrade snowpark lib until a fix is identified (#1928) * update release notes * update snapshot --------- Co-authored-by: Bruno Dufour <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Snowpark 1.26.0 breaks native app's snowpark integration. It looks like a new piece of logic was introduced that incorrectly assumes that Snowpark has a valid session, which is not the case when we execute Snowpark in the CLI sandbox. NADE will need to work with the Snowpark team on the fix or workaround, until then we shouldn't use the buggy library.