Move domain logic to individual processors #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bdufour
force-pushed
the
bdufour-dynamic-processor-reg
branch
2 times, most recently
from
eac2521 to
6b094b8
Compare
sfc-gh-pjafari
previously approved these changes
Dec 6, 2024
Comment on lines
179
to
182
| is_enabled_fn = getattr(processor_cls, "is_enabled", None) | ||
| if is_enabled_fn is None: | ||
| # No custom static method provided, enabled by default | ||
| return True |
There was a problem hiding this comment.
getattr(processor_cls, "is_enabled", lambda: True)
sfc-gh-pjafari
approved these changes
Dec 6, 2024
sfc-gh-astus
approved these changes
Dec 9, 2024
sfc-gh-bdufour
force-pushed
the
bdufour-dynamic-processor-reg
branch
from
38d3271 to
dceb994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
This change is part 1 of a series of refactorings aiming to enable the templates processor in domains other than native apps. This change specifically aims to move domain logic out of the compiler and into individual processors. This will facilitate moving the common portion of the processors to a shared location (under the
artifactsmodule in the CLI's API). Attempting to do so now would leave a significant number of references to native apps in common code, which I would prefer to avoid.