Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make version test resilient to new fields #1918

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Make version test resilient to new fields #1918

merged 1 commit into from
Dec 4, 2024

Conversation

sfc-gh-bdufour
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • (N/A) I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • (N/A) I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

There is a version integ test that is brittle in the face of new columns. This change makes it resilient to columns being added, without weakening the current assertions.

@sfc-gh-bdufour sfc-gh-bdufour marked this pull request as ready for review December 4, 2024 15:37
@sfc-gh-bdufour sfc-gh-bdufour requested a review from a team as a code owner December 4, 2024 15:37
@sfc-gh-bdufour sfc-gh-bdufour mentioned this pull request Dec 4, 2024
Closed
8 tasks
@sfc-gh-bdufour sfc-gh-bdufour merged commit fcd360d into main Dec 4, 2024
18 checks passed
@sfc-gh-bdufour sfc-gh-bdufour deleted the bdufour-fix-version-test branch December 4, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-melnacouzi sfc-gh-melnacouzi sfc-gh-melnacouzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-bdufour @sfc-gh-melnacouzi