Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional subdirectory for stage in application package #1916
base: main
Are you sure you want to change the base?
Add optional subdirectory for stage in application package #1916
Changes from 27 commits
8617252
5a3e154
8db7a40
d9eb5f4
71108d0
a7e3a20
99abebf
ce71ebf
855b413
68904aa
5fc642e
49275b9
04d807e
be0402b
ff369e7
31e1f70
f52c6cb
e95ab86
b663798
3412b3c
08a4110
c7a0a88
8153807
504f692
5cbf941
56fc4f6
b81670c
889c77e
44263ce
70e3d38
c0b0826
4ec1071
00db5a8
7f30fea
1921805
3f9ed94
d84a59c
d865ac8
dfb4373
aa80ac4
a225d44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made
diff
its own entity action.action_diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept current teardown functionality. Next PR, we will get and drop all app objects created from this package, not just what's listed in pdf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work with identifiers (quoted/unquoted)? or is this
==
overridden to do that, and if so, identifier could be String or Identifier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, you can take a look into package_entity.fqn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, replaced with
same_identifier