Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v2 tests #1887

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Add v2 tests #1887

merged 5 commits into from
Dec 4, 2024

Conversation

sfc-gh-jsikorski
Copy link
Contributor

@sfc-gh-jsikorski sfc-gh-jsikorski commented Nov 25, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Adding v2 versions for most of the test projects in unit tests for snowpark and streamlit

@sfc-gh-jsikorski sfc-gh-jsikorski marked this pull request as ready for review November 29, 2024 14:11
@sfc-gh-jsikorski sfc-gh-jsikorski requested review from a team as code owners November 29, 2024 14:11
@sfc-gh-jsikorski sfc-gh-jsikorski requested review from sfc-gh-astus and a team December 2, 2024 12:12
sfc-gh-astus
sfc-gh-astus previously approved these changes Dec 4, 2024
View reviewed changes
@sfc-gh-jsikorski sfc-gh-jsikorski enabled auto-merge (squash) December 4, 2024 09:37
@sfc-gh-jsikorski sfc-gh-jsikorski merged commit e9783ef into main Dec 4, 2024
18 checks passed
@sfc-gh-jsikorski sfc-gh-jsikorski deleted the jsikorski/v2_tests branch December 4, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jsikorski @sfc-gh-astus