Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1852178 Remove the deprecated part of API #791

Closed
wants to merge 6 commits into from
Closed

SNOW-1852178 Remove the deprecated part of API #791

wants to merge 6 commits into from

Conversation

sfc-gh-mmishchenko
Copy link
Contributor

@sfc-gh-mmishchenko sfc-gh-mmishchenko commented Dec 11, 2024 •
edited
Loading

  • Removed CRT function wrappers
  • Removed max LOB size as a macro
  • Removed deprecating macros as non-used anymore

@sfc-gh-mmishchenko sfc-gh-mmishchenko requested a review from a team as a code owner December 11, 2024 13:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-mmishchenko
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

sfc-gh-dprzybysz
sfc-gh-dprzybysz requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add Jira ID to the PR name
  2. The PR should be to master-2.0.0, not to the master branch

include/snowflake/SF_CRTFunctionSafe.h Show resolved Hide resolved
@sfc-gh-mmishchenko sfc-gh-mmishchenko changed the base branch from master to master-2.0.0 December 12, 2024 08:51
@sfc-gh-mmishchenko sfc-gh-mmishchenko changed the title Remove the deprecated part of API SNOW-1852178 Remove the deprecated part of API Dec 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@sfc-gh-mmishchenko sfc-gh-mmishchenko deleted the SNOW-1852178-Remove-deprecated-API-from-header-files branch December 12, 2024 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski Awaiting requested review from sfc-gh-jszczerbinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-mmishchenko @sfc-gh-dprzybysz @sfc-gh-ext-simba-hx @sfc-gh-jszczerbinski