Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-864140 update build scripts instruction #785

Merged
merged 6 commits into from
Dec 16, 2024
Merged

SNOW-864140 update build scripts instruction #785

merged 6 commits into from
Dec 16, 2024

Conversation

sfc-gh-ext-simba-hx
Copy link
Collaborator

teamwork issue 534
Update build/test scripts and instruction.

Tested on Windows VS14/VS17, Linux x86 Centos7+gcc8.3, Linux arm64 Ubuntu24.04+gcc13.2, MacOS13+Xcode14.2
The major changes are:

  • Fixed warnings in source code with higher version of compiler
  • Fixed issues with environment variable settings in build script (e.g. setting curdir could break build with VS14, setting AR in build_oob.sh could break curl build afterwards with Xcode14)
  • Fix test failures
  • Update build/test instruction

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx requested a review from a team as a code owner November 26, 2024 23:44
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx marked this pull request as draft November 27, 2024 00:41
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Nov 27, 2024
Open
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx marked this pull request as ready for review November 29, 2024 23:00
sfc-gh-jszczerbinski
sfc-gh-jszczerbinski reviewed Dec 2, 2024
View reviewed changes
tests/test_perf_string_reads_and_writes.c Show resolved Hide resolved
tests/test_column_fetch.c Outdated Show resolved Hide resolved
lib/results.c Show resolved Hide resolved
tests/test_perf_string_reads_and_writes.c Show resolved Hide resolved
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx mentioned this pull request Dec 4, 2024
Closed
@sfc-gh-dprzybysz
Copy link
Collaborator

All win builds on jenkins failed with missing artifacts to publish to S3 - I will post the buid logs in the internal channel

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx force-pushed the SNOW-864140-update-build-scripts-instruction branch from 0aef77a to fcc9a85 Compare December 6, 2024 18:35
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-864140-update-build-scripts-instruction branch from f6144e0 to e065be4 Compare December 16, 2024 06:39
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 9d050a6 into master Dec 16, 2024
45 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-864140-update-build-scripts-instruction branch December 16, 2024 09:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski sfc-gh-jszczerbinski approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-ext-simba-hx @sfc-gh-dprzybysz @sfc-gh-jszczerbinski