fix: remove unsafe interface conversion #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
sfc-gh-pfus
reviewed
Nov 6, 2023
|
Hi @Sugar-pack ! Thank you for your input. I asked for some clarification and can't wait to see your answers. |
sfc-gh-pfus
force-pushed
the
fix/unsafe-convertions
branch
from
9082216 to
89ceef3
Compare
|
@sfc-gh-pfus, could you please assist me in resolving test issues? |
|
@Sugar-pack of course. I took a look and it seems that only flaky tests failed. I restarted the failed builds. I'll let you know if there is anything needed from you. |
sfc-gh-pfus
force-pushed
the
fix/unsafe-convertions
branch
from
12225f2 to
0b997dd
Compare
sfc-gh-pfus
approved these changes
Nov 13, 2023
|
Thank you @Sugar-pack for your PR! I merged it :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a multi-valued interface conversion instead of a single-value form to avoid runtime panic.
Fix for #940
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them