Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-949229: support overwrite option in PUT #945

Merged
merged 9 commits into from
Oct 27, 2023
Merged

SNOW-949229: support overwrite option in PUT #945

merged 9 commits into from
Oct 27, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Oct 25, 2023 •
edited by sfc-gh-ext-simba-jl
Loading

Description

Supports overwrite in PUT commands. Before, overwrite retrieved from Snowflake was not taken into account.
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/712

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

sfc-gh-pfus
sfc-gh-pfus commented Oct 25, 2023
View reviewed changes
file_transfer_agent.go Show resolved Hide resolved
put_get_test.go Outdated Show resolved Hide resolved
put_get_test.go Outdated Show resolved Hide resolved
storage_client.go Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the put-overwrite-false branch 2 times, most recently from afb952c to 7e7d9b4 Compare October 25, 2023 10:23
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review October 25, 2023 10:24
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner October 25, 2023 10:24
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #945 (74615e5) into master (ce9ef59) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
+ Coverage   83.26%   83.28%   +0.02%     
==========================================
  Files          49       49              
  Lines        9340     9328      -12     
==========================================
- Hits         7777     7769       -8     
+ Misses       1563     1559       -4
Files Coverage Δ
auth.go 80.48% <100.00%> (+0.10%) ⬆️
authokta.go 78.42% <100.00%> (ø)
client.go 100.00% <100.00%> (ø)
connection.go 84.41% <ø> (ø)
dsn.go 87.57% <ø> (ø)
file_transfer_agent.go 75.32% <100.00%> (+0.21%) ⬆️
gcs_storage_client.go 86.82% <100.00%> (ø)
heartbeat.go 69.84% <100.00%> (ø)
restful.go 80.92% <100.00%> (-0.12%) ⬇️
s3_storage_client.go 90.67% <100.00%> (-0.19%) ⬇️
... and 4 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sfc-gh-dstempniak
sfc-gh-dstempniak reviewed Oct 25, 2023
View reviewed changes
storage_client.go Show resolved Hide resolved
put_get_test.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the put-overwrite-false branch 4 times, most recently from 85619d4 to ae5fb54 Compare October 25, 2023 13:05
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl changed the title support overwrite option in PUT SNOW-949229: support overwrite option in PUT Oct 25, 2023
@sfc-gh-pfus sfc-gh-pfus force-pushed the put-overwrite-false branch 7 times, most recently from 55837b6 to c43e608 Compare October 26, 2023 09:15
@sfc-gh-pfus sfc-gh-pfus force-pushed the put-overwrite-false branch 2 times, most recently from 46af9af to e95e188 Compare October 26, 2023 09:37
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit 28a31f0 into master Oct 27, 2023
23 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the put-overwrite-false branch October 27, 2023 02:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak left review comments

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl left review comments

@sfc-gh-dheyman sfc-gh-dheyman sfc-gh-dheyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pfus @sfc-gh-ext-simba-jl @sfc-gh-dstempniak @sfc-gh-dheyman