SNOW-949224 Introduce conn in async example #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #944 +/- ##
=======================================
Coverage 83.24% 83.24%
=======================================
Files 49 49
Lines 9340 9340
=======================================
Hits 7775 7775
Misses 1565 1565 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-dheyman
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change async mode used
sql.DBand invoking query caused synchronous logging in.Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them