Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr 509 #941

Closed
wants to merge 4 commits into from
Closed

Test pr 509 #941

wants to merge 4 commits into from

Conversation

sfc-gh-pfus
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

nyergler and others added 4 commits November 30, 2021 12:23
If the context has been set to Async Mode, the driver will attempt to
inspect the result type. If the result type has not been set, the driver
will panic when returning the [partial] result.
Set the result type before calling exec.
Unfotunately it appears that calling t.Fatalf in defer doesn't stop the
test, but it does display the error.
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner October 20, 2023 07:59
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #941 (e52e317) into master (0e5dfdd) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   83.24%   83.24%   -0.01%     
==========================================
  Files          49       49              
  Lines        9293     9340      +47     
==========================================
+ Hits         7736     7775      +39     
- Misses       1557     1565       +8     
Files Coverage Δ
connection.go 84.41% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants