Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-856228 better assertions in easy logging #933

Merged
merged 9 commits into from
Oct 17, 2023
Merged

SNOW-856228 better assertions in easy logging #933

merged 9 commits into from
Oct 17, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Oct 13, 2023 •
edited
Loading

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner October 13, 2023 13:18
sfc-gh-pfus
sfc-gh-pfus reviewed Oct 16, 2023
View reviewed changes
assert_test.go Outdated Show resolved Hide resolved
assert_test.go Show resolved Hide resolved
assert_test.go Outdated Show resolved Hide resolved
assert_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #933 (4146e2f) into master (5218d7a) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   83.24%   83.24%           
=======================================
  Files          49       49           
  Lines        9293     9293           
=======================================
  Hits         7736     7736           
  Misses       1557     1557
Files Coverage Δ
auth.go 80.38% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-knozderko
Copy link
Collaborator Author

a

sfc-gh-pfus
sfc-gh-pfus reviewed Oct 16, 2023
View reviewed changes
assert_test.go Outdated Show resolved Hide resolved
assert_test.go Outdated Show resolved Hide resolved
assert_test.go Outdated Show resolved Hide resolved
assert_test.go Show resolved Hide resolved
client_configuration_test.go Show resolved Hide resolved
@sfc-gh-knozderko
Copy link
Collaborator Author

b

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-856228_assertions branch from a6c75bb to 4c6fd22 Compare October 17, 2023 07:19
@sfc-gh-knozderko sfc-gh-knozderko merged commit c219d9d into master Oct 17, 2023
22 of 23 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-856228_assertions branch October 17, 2023 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-knozderko @sfc-gh-pfus