Fix TestConcurrentReadOnParams cleaning up the connection too early #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #926 +/- ##
=======================================
Coverage 83.24% 83.24%
=======================================
Files 49 49
Lines 9293 9293
=======================================
Hits 7736 7736
Misses 1557 1557 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-pfus
force-pushed
the
SNOW-894815-fix-mutex
branch
12 times, most recently
from
7e48b3a to
bef78ca
Compare
sfc-gh-pfus
changed the title
sfc-gh-pfus
force-pushed
the
SNOW-894815-fix-mutex
branch
from
bef78ca to
19684ca
Compare
sfc-gh-dheyman
approved these changes
Oct 16, 2023
sfc-gh-pfus
force-pushed
the
SNOW-894815-fix-mutex
branch
from
19684ca to
9b222b2
Compare
sfc-gh-pfus
force-pushed
the
SNOW-894815-fix-mutex
branch
from
9b222b2 to
d87b766
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test failed randomly when concurrent threads were run. If no row was read, the connection was returned to the pool too fast, before chunk decoding (in another thread) was finished. Currently, as we read from the rows, this object is not returned to the pool too early.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them