Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-856228 easy logging parser #924

Merged
merged 11 commits into from
Oct 13, 2023
Merged

SNOW-856228 easy logging parser #924

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
29b7ae1
SNOW-856228 easy logging parser
sfc-gh-knozderko Oct 9, 2023
c376725
fix linter comments
sfc-gh-knozderko Oct 11, 2023
04082c1
fix error message tests
sfc-gh-knozderko Oct 11, 2023
d087974
fix review comments
sfc-gh-knozderko Oct 11, 2023
39e613f
test for missing common
sfc-gh-knozderko Oct 11, 2023
a899c78
rename test
sfc-gh-knozderko Oct 12, 2023
1f5d0d5
make logLevel and logPath strings, not pointers
sfc-gh-knozderko Oct 12, 2023
67b8571
change variable names
sfc-gh-knozderko Oct 12, 2023
ac5b900
revert using assert library
sfc-gh-knozderko Oct 13, 2023
5212e1a
changes after review
sfc-gh-knozderko Oct 13, 2023
21daec9
Merge branch 'master' into SNOW-856228_easy_logging_parser
sfc-gh-knozderko Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions client_configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,22 @@ import (
"strings"
)

// log levels for easy logging
const (
Off string = "OFF"
Error string = "ERROR"
Warn string = "WARN"
Info string = "INFO"
Debug string = "DEBUG"
Trace string = "TRACE"
Off string = "OFF" // log level for logging switched off
sfc-gh-pfus marked this conversation as resolved.
Show resolved Hide resolved
sfc-gh-pfus marked this conversation as resolved.
Show resolved Hide resolved
Error string = "ERROR" // error log level
Warn string = "WARN" // warn log level
Info string = "INFO" // info log level
Debug string = "DEBUG" // debug log level
Trace string = "TRACE" // trace log level
)

// ClientConfig properties root
sfc-gh-knozderko marked this conversation as resolved.
Show resolved Hide resolved
type ClientConfig struct {
Common *ClientConfigCommonProps `json:common`
Common *ClientConfigCommonProps `json:"common"`
}

// ClientConfigCommonProps properties from "common" section
type ClientConfigCommonProps struct {
LogLevel *string `json:"log_level"`
LogPath *string `json:"log_path"`
Expand Down
Loading