Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-931952: Provide IncludeRetryReason config param #922

Merged
merged 1 commit into from
Oct 9, 2023
Merged

SNOW-931952: Provide IncludeRetryReason config param #922

merged 1 commit into from
Oct 9, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Oct 5, 2023 •
edited
Loading

Description

Provided IncludeRetryReason param to disable sending http status code with retries query requests.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review October 5, 2023 11:39
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner October 5, 2023 11:39
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Oct 5, 2023
View reviewed changes
dsn.go Outdated Show resolved Hide resolved
dsn_test.go Show resolved Hide resolved
retry_test.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-931952-include-retry-reason branch from a4a15b3 to 6315c32 Compare October 6, 2023 08:10
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-931952-include-retry-reason branch from 6315c32 to 0d3261b Compare October 6, 2023 08:13
@sfc-gh-pfus sfc-gh-pfus requested a review from a team October 9, 2023 06:35
@sfc-gh-pfus sfc-gh-pfus merged commit bec4641 into master Oct 9, 2023
21 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-931952-include-retry-reason branch October 9, 2023 07:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dheyman sfc-gh-dheyman sfc-gh-dheyman approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pfus @sfc-gh-dprzybysz @sfc-gh-dheyman