Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-878073 Refactor retry policy to support HTTP 503 & 429 #919

Merged
merged 23 commits into from
Oct 26, 2023

Conversation

sfc-gh-dheyman
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner October 2, 2023 09:03
@sfc-gh-dheyman sfc-gh-dheyman changed the title SNOW-878073 Refactor retry policy to support HTTP 503 & 429 DRAFT: SNOW-878073 Refactor retry policy to support HTTP 503 & 429 Oct 2, 2023
@sfc-gh-dheyman sfc-gh-dheyman changed the title DRAFT: SNOW-878073 Refactor retry policy to support HTTP 503 & 429 SNOW-878073 Refactor retry policy to support HTTP 503 & 429 Oct 2, 2023
retry.go Outdated Show resolved Hide resolved
retry.go Outdated Show resolved Hide resolved
retry.go Outdated Show resolved Hide resolved
retry.go Outdated Show resolved Hide resolved
retry.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #919 (0159c0f) into master (ce9ef59) will decrease coverage by 0.16%.
The diff coverage is 98.24%.

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   83.26%   83.11%   -0.16%     
==========================================
  Files          49       49              
  Lines        9340     9327      -13     
==========================================
- Hits         7777     7752      -25     
- Misses       1563     1575      +12     
Files Coverage Δ
auth.go 80.48% <100.00%> (+0.10%) ⬆️
authokta.go 78.42% <100.00%> (ø)
client.go 100.00% <100.00%> (ø)
connection.go 84.41% <ø> (ø)
dsn.go 87.57% <ø> (ø)
heartbeat.go 69.84% <100.00%> (ø)
restful.go 80.92% <100.00%> (-0.12%) ⬇️
telemetry.go 97.26% <100.00%> (ø)
util.go 98.26% <100.00%> (+0.09%) ⬆️
retry.go 93.65% <97.43%> (+4.81%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

retry.go Outdated Show resolved Hide resolved
retry_test.go Outdated Show resolved Hide resolved
retry_test.go Outdated Show resolved Hide resolved
retry.go Outdated Show resolved Hide resolved
@sfc-gh-dheyman sfc-gh-dheyman merged commit b540ce5 into master Oct 26, 2023
22 of 23 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the SNOW-878073-retry-strategy branch October 26, 2023 07:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants