SNOW-911238: Add WithOriginalTimestamp context switch #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-dstempniak
force-pushed
the
SNOW-911238-timestamp-overflow
branch
2 times, most recently
from
0eaf5dc to
b89711e
Compare
sfc-gh-dstempniak
force-pushed
the
SNOW-911238-timestamp-overflow
branch
from
b89711e to
dd1f4c7
Compare
sfc-gh-dstempniak
changed the title
| // ArrowSnowflakeTimestampToTime converts original timestamp returned by Snowflake to time.TIme | ||
| func ArrowSnowflakeTimestampToTime(rec arrow.Record, rb *ArrowBatch, colIdx int, recIdx int) *time.Time { | ||
| scale := int(rb.scd.RowSet.RowType[colIdx].Scale) | ||
| dbType := strings.ToUpper(rb.scd.RowSet.RowType[colIdx].Type) |
There was a problem hiding this comment.
perhaps we can encapsulate scale, dbtype and loc in a new structure? that way we wouldn't have to pass the whole ArrowBatch to the method? Just an idea
There was a problem hiding this comment.
I don't think it is a good option. In such case a driver user will have to extract data from ArrowBatch by himself and create such object to pass. Moreover scd and loc aren't public.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add WithOriginalTimestamp context switch.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them