SNOW-894815: Fix race conditions and enable TestConcurrentReadOnParams #909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/614
Fixes 2 race conditions by adding sync.Mutex locks:
sc.cfg.Params
map is being read in getQueryContextCacheSize() (same fix as Fix concurrent map read and write panic on connection parameter map #706)sc.cfg
is being read in decodeChunk() while cleanup() is trying to writeChecklist
make fmt
to fix inconsistent formatsmake lint
to get lint errors and fix all of them