Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-894815: Fix race conditions and enable TestConcurrentReadOnParams #909

Closed

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Sep 7, 2023

Description

Issue: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/614

Fixes 2 race conditions by adding sync.Mutex locks:

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl force-pushed the SNOW-894815-TestConcurrentReadOnParams branch from b8c6a93 to 8837b0e Compare September 26, 2023 19:39
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl changed the title Test PR for TestConcurrentReadOnParams SNOW-894815: Fix race conditions and enable TestConcurrentReadOnParams Sep 28, 2023
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review September 28, 2023 18:54
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner September 28, 2023 18:54
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl force-pushed the SNOW-894815-TestConcurrentReadOnParams branch from 56a9a8f to b0ac257 Compare October 12, 2023 15:36
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #909 (644b4c0) into master (46bf297) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 90.16%.

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
+ Coverage   83.22%   83.25%   +0.03%     
==========================================
  Files          48       49       +1     
  Lines        9244     9297      +53     
==========================================
+ Hits         7693     7740      +47     
- Misses       1551     1557       +6     
Files Coverage Δ
chunk_downloader.go 84.09% <100.00%> (ø)
connection.go 84.44% <100.00%> (+0.05%) ⬆️
connection_util.go 86.60% <100.00%> (+0.24%) ⬆️
htap.go 98.03% <100.00%> (+0.16%) ⬆️
rows.go 78.72% <100.00%> (ø)
client_configuration.go 86.04% <86.04%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl force-pushed the SNOW-894815-TestConcurrentReadOnParams branch from b0ac257 to 644b4c0 Compare October 13, 2023 17:28
@sfc-gh-pfus
Copy link
Collaborator

Fixed in #926

@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-894815-TestConcurrentReadOnParams branch October 23, 2023 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants